-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the wrong link auto-generation in the python generator #134
Fixes the wrong link auto-generation in the python generator #134
Conversation
Welcome @palnabarun! |
/cc @roycaihw |
1c82c0a
to
1c9ecb2
Compare
/assign |
/cc |
/lgtm |
/assign @brendandburns |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, palnabarun, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
Thank you @roycaihw @brendanburns for the approvals. :) |
The change in this PR makes sure that all instances of
kubernetes-kubernetes.client
are replaced bykubernetes-client
.Brief Background
gen/openapi/python.sh
Line 57 in f14e0bb
The above line replaces all instances of
client
withkubernetes.client
which has the side effect of changingpip install git+https://github.com/kubernetes-client/python.git
topip install git+https://github.com/kubernetes-kubernetes.client/python.git
.References
Fixes #133